Fix coo_map when only one match from regex pattern #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when using
coo_map
inMultiZarrToZarr
that was caused by using.groups()[0]
instead of.group()
, where there is only one returned regex match in the string (at least, as far as I can tell is the case).To fix this, I kept the original functionality but would catch if the
.groups()
tuple was empty. In the situation I ran into this bug, I used the following code which caused an IndexError due to a length 0 tuple:The string (and similar ones) that returned only one matching pattern to the regex was most recently:
/var/folders/vz/txd62qzn76g9f6cxg_8_76cw0000gn/T/tmp_kwkysl7/pres_msl_2002110200_p03_01.json
Where my goal was to subset the "p03" and other ensemble members from the GEFSv12 Retrospective data.
It seems this completely fixed the issue though happy to discuss or try some other edge cases.