Fixing c2mop:direct-slot-definition-class methods to return a class - #187
Merged
Merged
Conversation
Right now they return symbols, which is not the correct return type based on the AMOP Book Specification which is the official specification adopted by the ANSI Spec. See https://lisp-docs.github.io/cl-language-reference/meta-object-protocol/dictionary/direct-slot-definition-class and https://lisp-docs.github.io/cl-language-reference/meta-object-protocol/dictionary/effective-slot-definition-class Or http://metamodular.com/CLOS-MOP/direct-slot-definition-class.html and http://metamodular.com/CLOS-MOP/effective-slot-definition-class.html
Contributor
Author
|
Note that the current version (before the PR) works on SBCL, probably because it is more permissive, but the PR makes it be conformant with the Art of the Meta Object Protocol's (AMOP) definition |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now they return symbols, which is not the correct return type based on the AMOP Book Specification which is the official specification adopted by the ANSI Spec.
See
https://lisp-docs.github.io/cl-language-reference/meta-object-protocol/dictionary/direct-slot-definition-class
and
https://lisp-docs.github.io/cl-language-reference/meta-object-protocol/dictionary/effective-slot-definition-class
Or http://metamodular.com/CLOS-MOP/direct-slot-definition-class.html
and
http://metamodular.com/CLOS-MOP/effective-slot-definition-class.html