Skip to content

Fix sqlite3 migration expression with spurious () for null values #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fukamachi merged 1 commit into from
Apr 14, 2026
Merged

Fix sqlite3 migration expression with spurious () for null values #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/migration/table.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,15 @@ If this variable is T they won't be deleted after migration.")
append
(cond
((c2mop:slot-definition-initfunction slot)
(list
(cons (car new-column)
(convert-for-driver-type
:sqlite3
(table-column-type slot)
(dao-table-column-deflate slot
(funcall (c2mop:slot-definition-initfunction slot)))))))
(let ((value (convert-for-driver-type
:sqlite3
(table-column-type slot)
(dao-table-column-deflate
slot
(funcall (c2mop:slot-definition-initfunction slot))))))
(when value
(list
(cons (car new-column) value)))))
(t
(warn "Adding a non-null column ~S but there's no :initform to set default"
(car new-column))
Expand Down
Loading