Treat empty string as nil when inflating datetime/date columns - #198
Merged
Conversation
MySQL returns "" instead of nil for NULL timestamp/date columns. The inflate methods handled nil via etypecase but not "", causing local-time:parse-timestring to fail with an empty string input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
inflate-for-col-type, handle empty string""asnilfor:datetimeand:datecol-types (and their aliases:timestamp,:timestamptz).Why
When a column is declared
(or :null :timestamp)and the database stores""instead of NULL — which can happen with data imports, external tools, or direct SQL inserts that use empty string for missing dates —local-time:parse-timestringis called with""and raises an error. An empty string is never a valid timestamp, so treating it asnilis the right behavior.Fixes #197.