Export ResourceSourceInputObject, ResourceFunc & ResourceInput#569
Open
kgilden wants to merge 1 commit into
Open
Export ResourceSourceInputObject, ResourceFunc & ResourceInput#569kgilden wants to merge 1 commit into
kgilden wants to merge 1 commit into
Conversation
…outside Makes it easier to type hint resource sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier to type hint resource sources.
It's nice that the
resourceoption is flexible in what it accepts. However, it's not very nice to type hint something as beingResourceSourceInput. Modifying the resource option would require checking whether we're dealing with a function, an object, an array or a string. And that's quite painful. Much easier to just constrain a variable to being one specific type.Closes fullcalendar/fullcalendar#5797.