This repository was archived by the owner on May 17, 2019. It is now read-only.
Conversation
revskill10
reviewed
Sep 18, 2018
| // TODO(#46): this check should probably look at the asset manifest to ensure asset 404s are handled correctly | ||
| if (ctx.path.match(/\.(js|gif|jpg|png|pdf|json)$/)) return false; | ||
| if (ctx.path.startsWith(ctx.assetBase)) return false; | ||
| // The Accept header is a good proxy for whether SSR should happen |
Contributor
There was a problem hiding this comment.
We should use req.accepts(['html', 'json']) === 'html' instead ?
Contributor
There was a problem hiding this comment.
Should we also provide whitelist extensions as default for user to override/extend ?
Contributor
There was a problem hiding this comment.
What i want is to make sure default FusionJS website could be scraped and indexed by Bots.
Contributor
Author
|
Closing in favor of #299 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR further decouples fusion-core from fusion-cli.
Changes
ctx.rendered, rather than assuming howctx.bodygets constructed.ctx.assetBaserather than check extensions.