Draft
Conversation
tanzaku
approved these changes
Oct 24, 2025
ppputtyo
approved these changes
Oct 31, 2025
Collaborator
|
現時点ではルールが数個しかないため変更不要ですが、1点高速化案です。 現状は全てのルールでループを回し、全てのノードに対してルールに対応するか判定しているため、 以下のようにすることで計算量を
|
Co-authored-by: Taishi Naka <lemonadern@users.noreply.github.com>
Co-authored-by: Taishi Naka <lemonadern@users.noreply.github.com>
Co-authored-by: Taishi Naka <lemonadern@users.noreply.github.com>
Co-authored-by: Taishi Naka <lemonadern@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
uroborosql-fmtに linter を導入するための親 PR です。関連する PR をこのブランチに積んでいき、対応が完了次第 main に合流させます。
Checklist
uroborosql-lint-cliを追加no_distinctno_union_distincttoo_large_in_listno_not_inno_wildcard_projectionmissing_two_way_sampleno_function_on_column_in_join_or_whereuroborosql-lint側の config 解決処理uroborosql-lint-cliの--config対応vscode-uroborosql-fmt側で新しい language server 構成を利用できるようにする補足
もともと作業していた #216 は変更が試行錯誤のうちに様々な変更が混ざった大きな差分になりました(lint config 対応・language server 対応・ Node-API エントリポイント整理 等)
そのため個別の変更に切り分けて PR を出す方針とします。