Skip to content

Run tests on open PRs and fix invalid test case#929

Merged
chrnorm merged 1 commit intomainfrom
fix-tests-add-ci-step
Mar 28, 2026
Merged

Run tests on open PRs and fix invalid test case#929
chrnorm merged 1 commit intomainfrom
fix-tests-add-ci-step

Conversation

@meyerjrr
Copy link
Copy Markdown
Collaborator

@meyerjrr meyerjrr commented Mar 26, 2026

#914 introduced an invalid custom launch test which is failing.

This PR:

  • Removes the invalid test. It was asserting that using a custom command with --profile {{.profile}} with an empty profile set is a valid custom command that should be supported.
  • Due to tests not showing up on PR's from forked origins I missed this case before merging
  • Update workflows/test.yml to run on all pull requests

Copy link
Copy Markdown
Collaborator

@JoshuaWilkes JoshuaWilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrnorm chrnorm merged commit 27cd591 into main Mar 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants