This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Fix: Mark $unique property as nullable
#2048
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$unique` is `null` until `unique()` is called; marking it as such should make that clear.
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
============================================
+ Coverage 56.56% 56.65% +0.08%
Complexity 2068 2068
============================================
Files 306 306
Lines 4849 4849
============================================
+ Hits 2743 2747 +4
+ Misses 2106 2102 -4
Continue to review full report at Codecov.
|
|
It looks like CI failed due to some kind of transfer error on |
|
We have a psalm implementation discussion going so lets wait untill that is cleared up |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$uniqueisnulluntilunique()is called; marking it as nullable should make that clear.This came up for me because Psalm complains about subclasses of
Faker/Provider/Basenot initializing$unique.