Improvement: Added Invalid Date handling #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew when calendar is toggled. The view is focused on the current date instead of some day in 1899.
…string. This stops a parse error from firing.
barbossa
pushed a commit
to barbossa/angular-datepicker
that referenced
this pull request
Jul 3, 2016
Fixed error "Invalid date" g00fy-#183. For example, django rest framework return null if value is empty. Without this fix, I always get error "Invalid date"
Conflicts: app/scripts/datePicker.js app/scripts/input.js app/templates/datepicker.html bower.json dist/angular-datepicker.js dist/angular-datepicker.min.js package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement: Added Invalid Date handling for setting up the current view when calendar is toggled. The view is focused on the current date instead of some day in 1899.
My implementation has cases where "---" gets set on the model (multi-object editing related) which resulted in issues related to the datepicker starting at a date in the year 1899. The user would have to manually navigate back to more current years before they could narrow down the date they want to pick.
This fix shouldn't be affecting the model value at all.