Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline documentation updates #180

Open
wants to merge 4 commits into
base: schema-urgent-fixes
Choose a base branch
from

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented Nov 11, 2024

re-writing of some inline schema descriptions

This PR re-writes some of the root descriptions of the response type schemas (mostly) into slightly more verbose and formatted texts. Besides the "documentation is good" paradigm one reason is the intended use of these for generating documentation pages - see the (under construction) rendering at https://bycon.progenetix.org/generated/beacon-responses/

mbaudis and others added 3 commits July 19, 2024 10:43
* clarifications, rewording, example
* no schema changes
This commit re-writes some of the root descriptions of the response type schemas (mostly) into slightly more verbose and formatted texts. Besides the "documentation is good" paradigm one reason is the intended use of these for generating documentation pages - see the (under construction) rendering at https://bycon.progenetix.org/generated/beacon-responses/
@mbaudis
Copy link
Member Author

mbaudis commented Nov 11, 2024

Hi @jrambla and @costero-e - can you please have a look if there are any factual errors? Otherwise this should be fast paced into main - only inline documentation changes.

Note: I've done this also for having a single point of documentation texts and w/ some maturity we can co-opt this for docs.genomebeacons.org later on. See https://bycon.progenetix.org/API/

(updated with the canonical https://bycon.progenetix.org/API/ link)

Copy link
Collaborator

@costero-e costero-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mbaudis. I'm afraid this will conflict with the work in #174, that we are merging into clean-up. Either we wait until that is merged before or we work in the same PR. On the other hand, I see that we are only adding these modifications for .yml files but not for .json files, is there a specific reason for that? Thank you!

@mbaudis
Copy link
Member Author

mbaudis commented Nov 11, 2024

@costero-e Hmmm... Why would this conflict with #174 ? Beyond rebasing etc. things, potentially. And yes, I did not run the JSON converter before committing; added now.

@costero-e
Copy link
Collaborator

I was thinking in entryTypeDefinition.json file, which in #174 we are removing the filteringTerms entry and here is still existing. A same file modified by two different commits that are unaligned will make git complain I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants