feat: support for 9.2 #34
Open
+71
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for IDA Pro 9.2 by implementing PySide6 compatibility alongside the existing PyQt5 support. The changes ensure the plugin works with both older and newer versions of IDA Pro.
- Adds conditional imports for PySide6 when IDA SDK version is 9.2 or higher
- Updates Qt wrapper instances to use shiboken6 instead of sip for IDA 9.2+
- Bumps plugin version to 0.3.0 and updates copyright year to 2025
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/patching/util/qt.py | Adds PySide6 import logic for IDA 9.2+ with fallback to PyQt5 for older versions |
| plugins/patching/util/ida.py | Updates Qt menu wrapping to use shiboken6 for IDA 9.2+ and fixes super() call |
| plugins/patching/core.py | Updates plugin version to 0.3.0 and copyright year to 2025 |
| plugins/patching.py | Replaces ida_idaapi imports with idaapi and adds addon registration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.