Skip to content

Nitpicky or n00b?#10

Open
memoia wants to merge 3 commits intogadabout:masterfrom
memoia:nitpicky
Open

Nitpicky or n00b?#10
memoia wants to merge 3 commits intogadabout:masterfrom
memoia:nitpicky

Conversation

@memoia
Copy link

@memoia memoia commented Oct 30, 2014

Help! Not a node expert ... but, this happens when running npm start off master. At least, for me.

screen shot 2014-10-29 at 10 26 56 pm

Something's gone wrong somewhere, I guess. Here are the versions of things that npm install grabbed:

$ grep '"version":' $(find node_modules -maxdepth 2 -iname 'package.json' | xargs)
node_modules/bower/package.json:  "version": "1.3.12",
node_modules/browserify/package.json:  "version": "4.2.3",
node_modules/connect/package.json:  "version": "2.27.2",
node_modules/gulp/package.json:  "version": "3.8.9",
node_modules/gulp-concat/package.json:  "version": "2.4.1",
node_modules/gulp-jade/package.json:  "version": "0.5.0",
node_modules/gulp-less/package.json:  "version": "1.3.6",
node_modules/gulp-livereload/package.json:  "version": "1.5.0",
node_modules/gulp-streamify/package.json:  "version": "0.0.5",
node_modules/gulp-uglify/package.json:  "version": "0.3.2",
node_modules/gulp-util/package.json:  "version": "2.2.20",
node_modules/knockout/package.json:  "version": "3.2.0",
node_modules/moment/package.json:  "version": "2.8.3",
node_modules/superagent/package.json:  "version": "0.18.2",
node_modules/vinyl-source-stream/package.json:  "version": "0.1.1",

At least, in my case. A bug to be fixed in the future, maybe.
For now, I just want to use the project to func-test the API.
@doughsay
Copy link
Contributor

Hey, thanks for the commits! I'm not a fan of the changes to package.json though... I'm ok with splitting the watch task out on it's own, but the default npm start should build all the files in addition to starting the server. Or, at the very least, the readme would have to be updated to let people know they'd need to run npm run-script build before running npm start. If you address that, I'd be happy to merge in your changes.

@doughsay
Copy link
Contributor

Oh, and I checked, you're right. Livereload causes a crash on node 0.10.18. I'm using 0.10.32 so I never noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants