Default shouldEmitPatchOnChange to false #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-rc
force-pushed
the
sc/default-should-track-changes-to-false
branch
from
6b22061
to
cd3d23f
Compare
scott-rc
commented
Jul 11, 2024
| @@ -72,27 +72,6 @@ describe("class model snapshotted views", () => { | |||
| expect(instance.slug).toEqual("test"); | |||
| }); | |||
|
|
|||
| test("an observable instance emits a patch when the view value changes", () => { | |||
There was a problem hiding this comment.
This test is already covered inside the describe("shouldEmitPatchOnChange", ...) tests.
CodSpeed Performance ReportMerging #108 will improve performances by 60.91%Comparing Summary
Benchmarks breakdown
|
thegedge
approved these changes
Jul 11, 2024
airhorns
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
shouldEmitPatchOnChangein #107, but defaulted it to true.After starting to use
shouldEmitPatchOnChangein Gadget, we realized that users should opt-in to emitting patches for snapshotted view changes rather than having to opt-out. This PR fixes that.This is technically a breaking change but since so few people use mobx-quick-tree and #107 has been released for less than 24h this should be fine.