Skip to content

Check the status code from the CONNECT response when the proxy is HTTP and the target is HTTPS. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −1
Open

Check the status code from the CONNECT response when the proxy is HTTP and the target is HTTPS. #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b79531
Check the status code from the CONNECT response when the proxy is HTT…
Jan 8, 2023
3808964
Check the status code from the CONNECT response when the proxy is HTT…
Jan 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/classes/HttpsProxyAgent.ts
View file
Original file line number Diff line number Diff line change
@@ -40,7 +40,20 @@ class HttpsProxyAgent extends Agent {
callback(error);
});

socket.once('data', () => {
socket.once('data', (data) => {
// Proxies with HTTPS as protocal are not allowed by parseProxyUrl(), so it should be safe to assume that the response is plain text
const statusLine = data.toString().split('\r\n')[0];
const statusLineExp = /^HTTP\/(\d)\.(\d) (\d{3}) ?(.*)$/;

const statusCode = statusLineExp.exec(statusLine)?.[3];

if (typeof statusCode === 'string' && +statusCode >= 400) {
const err = new Error(`Proxy server refused connecting to '${configuration.host}:${configuration.port}' (${statusLine})`);
callback(err);
socket.destroy();
return;
}

const secureSocket = tls.connect({
...configuration.tls,
socket,