Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use deep semver import #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Use deep semver import #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/factories/createGlobalProxyAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
import {
omitUndefined,
} from 'omit-undefined';
import semver from 'semver';
import semverGte from 'semver/functions/gte';
import Logger from '../Logger';
import {
HttpProxyAgent,
Expand Down Expand Up @@ -144,7 +144,7 @@ export default (configurationInput: ProxyAgentConfigurationInputType = defaultCo

// Overriding globalAgent was added in v11.7.
// @see https://nodejs.org/uk/blog/release/v11.7.0/
if (semver.gte(process.version, 'v11.7.0')) {
if (semverGte(process.version, 'v11.7.0')) {
// @see https://github.com/facebook/flow/issues/7670
// @ts-expect-error Node.js version compatibility
http.globalAgent = httpAgent;
Expand All @@ -161,7 +161,7 @@ export default (configurationInput: ProxyAgentConfigurationInputType = defaultCo
//
// We still want to override http(s).globalAgent when possible to enable logic
// in `bindHttpMethod`.
if (semver.gte(process.version, 'v10.0.0')) {
if (semverGte(process.version, 'v10.0.0')) {
// @ts-expect-error seems like we are using wrong type for httpAgent
http.get = bindHttpMethod(httpGet, httpAgent, configuration.forceGlobalAgent);

Expand Down