missing drmaa_lib env in systemd file #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a variable for more flexibility
natefoo
reviewed
Aug 14, 2020
Member
There was a problem hiding this comment.
Thanks @bruggerk! I've made a couple of minor suggestions, and unfortunately this will need to be rebased or merged for some conflicting changes I made in the past few days. Sorry for not getting to this first.
Additionally, could you add a default for the new variable (I renamed it to make its purpose a bit more obvious, as well) in defaults/main.yml please?:
pulsar_systemd_service_template: "pulsar.service.j2"| - name: Create Pulsar systemd unit file | ||
| template: | ||
| src: "pulsar.service.j2" | ||
| src: "{{pulsar_systemd_file}}" |
Member
There was a problem hiding this comment.
Suggested change
| src: "{{pulsar_systemd_file}}" | |
| src: "{{ pulsar_systemd_service_template }}" |
Comment on lines
+19
to
+20
| {% if pulsar_drmaa_library_path %} | ||
| Environment=DRMAA_LIBRARY_PATH={{pulsar_drmaa_library_path}} |
Member
There was a problem hiding this comment.
Suggested change
| {% if pulsar_drmaa_library_path %} | |
| Environment=DRMAA_LIBRARY_PATH={{pulsar_drmaa_library_path}} | |
| {% if pulsar_drmaa_library_path is defined %} | |
| Environment="DRMAA_LIBRARY_PATH={{ pulsar_drmaa_library_path }}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the missing environmental vairable DRMAA_LIBRARY_PATH to pulsar_drmaa_library_path if this is sat in the playbook.
Otherwise pulsar cannot find the drmaa library when run through systemd
Also made the file template as an ansible variable so it can easier be modified without changing the ansible role