-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add differential expression workflow under feature flag (#1054) #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Create shared WorkflowAccordion component for workflow display - Add differential expression workflow constants and configuration - Gate DE workflow behind "de" feature flag - Update AnalysisMethodsCatalog to use new shared component 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds support for a new Differential Expression (DE) workflow behind a feature flag, and refactors the workflow selection UI for better extensibility. The changes introduce a new workflow type that can be enabled/disabled via a feature flag, and generalizes the workflow accordion component to support multiple workflow types.
- Adds a new differential expression workflow with feature flag control
- Refactors CustomWorkflow component into a generic WorkflowAccordion component
- Updates routing and workflow loading to accommodate the new workflow
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pages/_app.tsx |
Enables the "de" feature flag globally |
pages/data/[entityListType]/[entityId]/[trsId]/index.tsx |
Adds static path generation for the DE workflow |
app/views/WorkflowInputsView/workflowInputsView.tsx |
Adds feature flag check to control access (contains bug) |
app/services/workflows/loader.ts |
Registers the DE workflow in the workflow store |
app/components/Entity/components/ConfigureWorkflowInputs/components/Main/components/Stepper/steps/utils.ts |
Adds step configuration for the DE workflow |
app/components/Entity/components/AnalysisMethodsCatalog/analysisMethodsCatalog.tsx |
Conditionally displays DE workflow based on feature flag |
app/components/Entity/components/AnalysisMethod/components/WorkflowAccordion/workflowAccordion.tsx |
Refactored from CustomWorkflow to be generic and reusable |
app/components/Entity/components/AnalysisMethod/components/WorkflowAccordion/workflowAccordion.styles.ts |
Styling for the generic WorkflowAccordion component |
app/components/Entity/components/AnalysisMethod/components/WorkflowAccordion/types.ts |
Generic props interface for WorkflowAccordion |
app/components/Entity/components/AnalysisMethod/components/DifferentialExpressionWorkflow/constants.ts |
Defines the DE workflow configuration |
app/components/Entity/components/AnalysisMethod/components/CustomWorkflow/types.ts |
Removed unused Props interface |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Closes #1054.
This pull request introduces support for a new Differential Expression (DE) workflow, controlled by a feature flag, and refactors the workflow selection UI for better extensibility. The changes ensure that the DE workflow is only available when the feature flag is enabled, and update the codebase to generalize workflow selection and configuration. Additionally, the pull request updates routing and workflow loading to accommodate the new workflow.
Differential Expression Workflow Integration:
DIFFERENTIAL_EXPRESSION_WORKFLOWconstant and integrated it into the workflow catalog, loader, and routing, enabling users to select and configure this workflow when the "de" feature flag is enabled. [1] [2] [3] pages/data/[entityListType]/[entityId]/[trsId]/index.tsxR23, pages/data/[entityListType]/[entityId]/[trsId]/index.tsxR114-R122)Feature Flag Management:
Workflow UI Refactor:
WorkflowAccordioncomponent, allowing for easier addition of new workflows and supporting custom button text and workflow data. [1] [2] [3] [4] [5]Code Cleanup:
Propsinterface from the old custom workflow types, as the new component takes a more general set of props.