fix: no results on ena picker when pre filters do not match (#778) #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the ENA picker returned no results when pre-filters didn't match data by refactoring the column filter validation logic. The new approach validates the entire combination of filters rather than individual values, ensuring only filter combinations that match at least one table row are applied.
- Replaced individual column/value validation with combination-based validation
- Added utility function for consistent value-to-string-array conversion
- Changed validation to only apply filters when at least one row matches all filter criteria
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ents/Step/SequencingStep/components/ENASequencingData/components/CollectionSelector/utils.ts
Show resolved
Hide resolved
...ents/Step/SequencingStep/components/ENASequencingData/components/CollectionSelector/utils.ts
Show resolved
Hide resolved
|
|
||
| return columnFiltersState; | ||
| function toStringArray(value: unknown): string[] { | ||
| if (value == null) return []; |
There was a problem hiding this comment.
Checking == is intentional here.
There was a problem hiding this comment.
LOL, no. I let Windsurf write that function 😱 .
MillenniumFalconMechanic
approved these changes
Sep 5, 2025
frano-m
commented
Sep 7, 2025
|
|
||
| return columnFiltersState; | ||
| function toStringArray(value: unknown): string[] { | ||
| if (value == null) return []; |
There was a problem hiding this comment.
Suggested change
| if (value == null) return []; | |
| if (value === null) return []; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #778.
This pull request refactors the logic for building validated column filters in the
CollectionSelectorutility by introducing a new approach that ensures only filter combinations that match at least one row in the table are applied. The previous implementation, which filtered out invalid columns and values individually, has been replaced with a stricter validation that checks the overall combination of filter values for validity. Additionally, a new utility function for value conversion was added.Key changes:
Column Filter Validation Logic:
buildValidatedColumnFiltersimplementation with a new version that only applies preselected filters if at least one row in the table matches all filters (AND across columns, OR within a column). If no such row exists, no filters are applied. This ensures only valid filter combinations are used.Utility Functions:
toStringArrayutility function to consistently convert values to string arrays, improving type safety and code clarity.