Skip to content

Conversation

@uwwint
Copy link
Contributor

@uwwint uwwint commented Oct 16, 2025

Description

On the path to create oauth2 proxy and refactor search functionality. This needs some TLC before it can be merged.

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • ⬆️ Dependency update
  • 🧰 Maintenance/chore

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Related Issues

Closes #

@uwwint
Copy link
Contributor Author

uwwint commented Nov 20, 2025

This change allows the MCP server to run as a Remote MCP server with user login.
Screenshot 2025-11-20 at 21 05 31
Screenshot 2025-11-20 at 21 06 11
Screenshot 2025-11-20 at 21 06 32
<img width="1563" height="983" alt="Screenshot 2025-11-20 at 21 08 04" src="https://github.com/user-attac
Screenshot 2025-11-20 at 21 10 17
hments/assets/01bf541a-61a7-40d5-b555-e935fe71caee" />

@bgruening
Copy link
Member

@uwwint can you please rebase this PR?

@uwwint
Copy link
Contributor Author

uwwint commented Nov 20, 2025

@bgruening done

- Add type: ignore for intentional method monkey-patching
- Fix history_id type handling in get_job_details (only use provenance when history_id provided)
- Declare result_path as str | bytes union for download_dataset
- Fix port resolution to avoid int() on already-int value
- Use Literal type for transport argument with cast after validation
- Update test to pass history_id for provenance path
- Fix scopes argument to always provide a list (not None)
- Remove unsupported 'resource' arg from AuthorizationCode
- Remove unsupported 'claims' arg from AccessToken
- Remove @OverRide from methods that don't override parent
- Add type: ignore for super().get_routes() call
- Fix form field type handling for username/password
@dannon dannon merged commit 652b1c3 into galaxyproject:main Dec 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants