-
Notifications
You must be signed in to change notification settings - Fork 15
Fix #19: add dataset collection support and robust collection detection #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #19: add dataset collection support and robust collection detection #26
Conversation
…ction detection
|
This PR fixes Issue #19 and enables robust handling of dataset collections in Galaxy MCP, which is critical for agent-native workflows and LLM integrations. What it does:
Tests included:
This change is backward-compatible and purely additive, and should help unblock agent workflows that need to navigate collections. Happy to make any adjustments if needed! 🙌 |
|
Welcome @ldalcolmo! I started the CI :) |
Thanks @bgruening! |
|
Thanks for this contribution! Adding collection support is a welcome improvement! A couple of things I noticed:
The new |
|
Thanks a lot for the review and the kind words! 🙏 Performance: agreed — switching from gi.datasets.get_datasets() (server-side pagination) to show_history(contents=True) does fetch all items and paginates client-side. I’ll add an explicit comment/docstring note explaining the tradeoff and why it’s needed to include dataset collections. Unused details parameter: good catch — it’s now redundant in the new implementation. I’ll remove it (and update call sites/tests accordingly). Test docstring placement: also agreed — I’ll move those docstrings to be the first statement in the test methods. I’ll push a small follow-up commit with these changes shortly. Will ping you once CI is green again.
|
dannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Thanks a lot for the review and approval! If there are other MCP or Galaxy integration issues where I can help, feel free to point me to them — happy to contribute. |
Description
This PR fixes Issue #19 by adding native support for dataset collections in Galaxy MCP, enabling agent workflows to correctly discover, inspect, and navigate histories that contain collections.
It introduces:
get_history_contents()get_collection_details()for inspecting collection structure and membersget_dataset_details()to prevent agents from treating collections as datasetsThese changes make Galaxy MCP fully usable in agent-native environments where histories frequently contain list, paired, or nested dataset collections.
Type of Change
Checklist
Related Issues
Closes #19