Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.01] Passing Identifier for div to Write the Chart Panel to #16598

Merged

Conversation

assuntad23
Copy link
Contributor

@assuntad23 assuntad23 commented Aug 25, 2023

Fix for #16191

Moving this change to a separate PR since it should target a different release branch
See PR #16593 for additional details, relevant description copied below.

After making the other changes in that PR, I was getting a 200 response, but still was not able to view the chart, whereupon I dug around the dev console long enough to find that target was undefined, since it was misnamed as targets as a parameter. After fixing that, the boxplot renders fine. 😅

How to test the changes?

(Select all options that apply)

  • Instructions for manual testing are as follows:
    1. Create a tabular file
    2. Create a boxplot visualization for it
    3. Check the visualization under Users > Visualizations
    4. Note that the graph is visible

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 22.05 milestone Aug 25, 2023
@assuntad23 assuntad23 changed the title passing identifier for div to write the chart panel to Passing Identifier for div to Write the Chart Panel to Aug 25, 2023
@martenson martenson changed the title Passing Identifier for div to Write the Chart Panel to [22.01] Passing Identifier for div to Write the Chart Panel to Aug 25, 2023
@mvdbeek mvdbeek merged commit a03856c into galaxyproject:release_22.01 Aug 30, 2023
29 of 35 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Aug 30, 2023

Thank you @assuntad23!

@galaxyproject galaxyproject deleted a comment from github-actions bot Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants