-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a button that filters out a tool section in the tool panel #18034
Add a button that filters out a tool section in the tool panel #18034
Conversation
This allows users to filter on tool ids or sections if they specify `id:tool_id` or `section:Section name`. Fixes galaxyproject#17741
Searching by |
Yes, this just adds the section filter as well |
I think this does what it advertises, maybe a little confusing is that However to me this PR does not seem enough to close #17741. Notably the user has to know the syntax of Note that similar functionality for showing all tools within a section has already existed in the advanced search. ping @jennaj -- do you have an idea what you'd like to see here? |
I suggest we do not show the buttons when the tool panel is in "browsing" mode. It feels like a clutter since it basically duplicates expanding a section and takes a lot of real estate. I think the situations where we want to have access to this functionality are: |
I pushed a small style change. The tooltips do not seem to respect the settings here, (since to the |
Thank you @martenson !
Yes, good point, I agree that the icons should only appear when browsing; i.e.: when there is a filter active. |
This looks good, but +1 to tweaking it slightly as @martenson suggests to only show the filter toggles based on context. |
also prevent the search bar from yelling at me and downgrade "danger" to info and warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a small bugfix and a style change. Thank you @ahmedhamidawan !
Adds a button that only shows the desired tool section in the panel (by emitting a
section:Section Name
filter:Users can filter on tool ids or sections if they specify
id:tool_id
orsection:Section name
in the search bar.Fixes #17741
How to test the changes?
(Select all options that apply)
License