Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play nice with password managers #18206

Merged
merged 1 commit into from
May 23, 2024
Merged

Play nice with password managers #18206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/src/components/Login/ChangePassword.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ async function submit() {

<BCard header="Change your password">
<BFormGroup v-if="expiredUser" label="Current Password">
<BFormInput v-model="current" type="password" />
<BFormInput v-model="current" type="password" autocomplete="current-password" />
</BFormGroup>

<BFormGroup label="New Password">
<BFormInput v-model="password" type="password" />
<BFormInput v-model="password" type="password" autocomplete="new-password" />
</BFormGroup>

<BFormGroup label="Confirm password">
<BFormInput v-model="confirm" type="password" />
<BFormInput v-model="confirm" type="password" autocomplete="new-password" />
</BFormGroup>

<BButton type="submit">Save new password</BButton>
Expand Down
3 changes: 2 additions & 1 deletion client/src/components/Login/LoginForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,8 @@ function returnToLogin() {
required
:state="passwordState"
name="password"
type="password" />
type="password"
autocomplete="current-password" />

<BFormText v-if="showResetLink">
<span v-localize>Forgot password?</span>
Expand Down
2 changes: 2 additions & 0 deletions client/src/components/Login/RegisterForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ async function submit() {
v-model="password"
name="password"
type="password"
autocomplete="new-password"
required />
</BFormGroup>

Expand All @@ -153,6 +154,7 @@ async function submit() {
v-model="confirm"
name="confirm"
type="password"
autocomplete="new-password"
required />
</BFormGroup>

Expand Down
Loading