-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libraries Modernisation: Directory Dataset Picker #18638
Open
itisAliRH
wants to merge
18
commits into
galaxyproject:dev
Choose a base branch
from
itisAliRH:libraries-modernization-1-directory-dataset-picker
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Libraries Modernisation: Directory Dataset Picker #18638
itisAliRH
wants to merge
18
commits into
galaxyproject:dev
from
itisAliRH:libraries-modernization-1-directory-dataset-picker
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itisAliRH
force-pushed
the
libraries-modernization-1-directory-dataset-picker
branch
2 times, most recently
from
August 2, 2024 13:41
11cf6e3
to
f169c1f
Compare
…n` `Option` interface
…lldown` items and import missing icons
itisAliRH
force-pushed
the
libraries-modernization-1-directory-dataset-picker
branch
from
September 16, 2024 11:57
f169c1f
to
3e5bea1
Compare
… list and making the import button dynamic to reflect the number of selected items being import
…label` prop, revised selected item type, and update its usage
…tching logic, improved types, and adjusted ui in `DirectoryDatasetPicker`
…errors when there is no option available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on #18518 and replaces the old dataset picker from user and import directories and path to the library folder. Also, remove the
jstree
and related files (related #18451)Libraries.Modernisation.Directory.Dataset.Picker.webm
How to test the changes?
(Select all options that apply)
Data Libraries
Dataset > User directory
or fromDataset > from import directory
Dataset > from path
as adminLicense