[24.1] Fix very slow workflow editor loading #19068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the editor for my usegalaxy.org account takes 20 seconds. I've narrowed this down to the unnecessary join against the workflow table and loading all steps. I'm also returning the needed columns directly.
The query is still about 1 second if the database cache is not hot (on consecutive execution the query finishes in ~ 7ms) with no obvious room for improvement (except for composite index), but I think with #18729 we might not have to load up the full list of workflows and step counts ahead of time anymore.
How to test the changes?
(Select all options that apply)
License