Skip to content

Fixes for GButtons with disabled state #20121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ahmedhamidawan
Copy link
Member

There are 2 fixes here:

Bug: GButton routes when disabled

prevent_routing_g_button
We were able to route to the provided to or href even if the GButton was disabled. Now we prevent that by setting those values based on the disabled prop.

Bug: Transparent GButton with disabled state not obvious

A GButton with both transparent and disabled props as true did not show any visual difference. Now we enforce the color to gray in this case.

Before 🐞 After ✅
disabled_transparent_g_button_BEFORE disabled_transparent_g_button_AFTER

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Otherwise, for `GButton`s with the `transparent` prop, the disabled state is not visible.
@ahmedhamidawan
Copy link
Member Author

Failing Selenium tests are unrelated

Failing Integration Selenium should also be unrelated:

FAILED test/integration_selenium/test_user_file_source_ftp.py::TestObjectStoreSelectionSeleniumIntegration::test_create_and_use -
selenium.common.exceptions.TimeoutException: Message: Timeout waiting on CSS selector [#user-file-sources-index] to become present.

#user-file-sources-index is a BTable

@mvdbeek
Copy link
Member

mvdbeek commented May 2, 2025

#user-file-sources-index is a BTable

But it fails to be routed there because we don't wait for the button state to become enabled. Which was tricky to spot because of this bug 😆. That's gonna be fixed in #20131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants