Fixes for GButtons with disabled state #20121
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 fixes here:
Bug:
GButton
routes when disabledWe were able to route to the provided
to
orhref
even if theGButton
was disabled. Now we prevent that by setting those values based on thedisabled
prop.Bug: Transparent
GButton
withdisabled
state not obviousA
GButton
with bothtransparent
anddisabled
props as true did not show any visual difference. Now we enforce thecolor
togray
in this case.How to test the changes?
(Select all options that apply)
License