Customizable Pulsar test file server port and files endpoint #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Read port at which the Pulsar test file server should listen from `PULSAR_TEST_FILE_SERVER_PORT`. - Make the files endpoint customizable via a new `PULSAR_TEST_INTERNAL_JOB_FILES_URL` variable. - Use `PULSAR_TEST_FILE_SERVER_HOST` only for the test file server (rather than also using it for the test Pulsar app). These changes make it possible to expose the files server via port-forwarding (since the files server port is now predictable). This is useful for testing the upcoming staging delegation with an external service (e.g. ARC).
kysrpex
commented
Jul 17, 2025
Comment on lines
-258
to
260
| app = test_app.app | ||
| create_kwds = { | ||
| } | ||
| if os.environ.get("PULSAR_TEST_FILE_SERVER_HOST"): | ||
| create_kwds["host"] = os.environ.get("PULSAR_TEST_FILE_SERVER_HOST") | ||
|
|
||
| create_kwds = {} | ||
| if host: | ||
| create_kwds["host"] = host | ||
| if port: | ||
| create_kwds["port"] = port | ||
|
|
||
| server = StopableWSGIServer.create(app, **create_kwds) |
Contributor
Author
There was a problem hiding this comment.
For reviewers: now the test Pulsar app won't bind to PULSAR_TEST_FILE_SERVER_HOST (only the files server). Please consider whether this is a breaking change before approving the changes from the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULSAR_TEST_FILE_SERVER_PORT.PULSAR_TEST_INTERNAL_JOB_FILES_URLvariable.PULSAR_TEST_FILE_SERVER_HOSTonly for the test file server (rather than also using it for the test Pulsar app).These changes make it possible to expose the files server via port-forwarding (since the files server port is now predictable). This is useful for testing the upcoming staging delegation with an external service (e.g. ARC).