-
Notifications
You must be signed in to change notification settings - Fork 55
Add pulsar relay mode #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Implements the pulsar client and server parts of galaxyproject#417
Is calling it a proxy a like common pattern or something I'm missing. I read through the whole PR and I think it is very exciting but I don't understand the messaging. It is a different message communication schema than AMQP but it is a similar idea right? Why is this a proxy but we wouldn't call AMQP a proxy? I would call it like reverse long polling or something instead but I may just be not seeing it through your eyes. |
yeah, it's not a exactly a proxy .. messages pass unmodified between pulsar and galaxy and yes, the messages are the same as what we use with amqp modality. pulsar-proxy can also do websockets, and we should probably switch transparently between these when websockets are an option. which direction is reverse in the long polling scheme ? Do you like one of these ?
long polling is just the modality I've implemented for now, I'd like to keep that a detail and call both the server (what I call |
Bit of a chicken and egg, but the integration test in galaxyproject/galaxy#21118 passes locally. |
Very exciting! Thank you so much for pushing in this direction - how did Claude do with Pulsar - any lessons learned? Did you make any CLAUDE.md files or anything to help it out? |
1. **Galaxy → Pulsar**: Galaxy posts control messages (job setup, status requests, | ||
kill commands) to the proxy via HTTP POST | ||
2. **Pulsar → Galaxy**: Pulsar polls the proxy via HTTP long-polling to receive | ||
these messages | ||
3. **Pulsar → Galaxy**: Pulsar posts status updates to the proxy | ||
4. **Galaxy → Pulsar**: Galaxy polls the proxy to receive status updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these be:
- Galaxy -> proxy
- proxy -> Pulsar
- Pulsar -> proxy
- Proxy -> Galaxy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, and I thought I changed the language to relay 🤔
I'm rarely using claude.md, I started with this prompt:
and then reviewed the plan and let it do its thing. The next prompt was
😅 |
Does this retry all message types, or just status updates? |
No description provided.