Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ampvis2 export otu #6748

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paulzierep
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

ping @bernt-matthias
pretty useful for downstream analysis after subsampling

<output name="otu_short" value="output_otu_short.tsv" ftype="tabular" />
<output name="tax" value="output_otu_taxonomy_mapping.tsv" ftype="tabular" />
<output name="meta" value="output_metadata.tsv" ftype="tabular" />
<output name="phyloseq" value="output_phyloseq.rds" ftype="phyloseq" compare="sim_size" delta_frac="0.1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a has_size content assertion and remove output_phyloseq.rds

Comment on lines +70 to +74
<data name="otu_long" format="tabular" label="${tool.name}: Long OTU" />
<data name="otu_short" format="tabular" label="${tool.name}: Short OTU"/>
<data name="tax" format="tabular" label="${tool.name}: Taxonomy mapping" />
<data name="meta" format="tabular" label="${tool.name}: Metadata mapping" />
<data name="phyloseq" format="phyloseq" label="${tool.name}: Phyloseq object" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make all of them optional? Controlled by a single select (by using min="1" we can enforce that at least one option is selected).

Comment on lines +1 to +2
SampleID Plant Date Year Period V6
16SAMP-747 16SAMP-747 Aalborg East 2010-02-04 2010 Winter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow we get an additional V6 in the column header. I guess you need to disable row names in the output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to fix this I discovered, that the original input to create that ampvis2 object actually only has 4 columns (https://github.com/galaxyproject/tools-iuc/blob/main/tools/ampvis2/test-data/AalborgWWTPs.tsv), even when ampvis adds the first unnamed column as sampleID, this is pretty strange ... but seems to lead to this issue when exporting.

	Plant	Date	Year	Period
16SAMP-747	16SAMP-747	Aalborg East	2010-02-04	2010	Winter

When exporting using e.g. the subset it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants