Fix unity versions scrapping not getting all the versions

[brako]

Changes

This pull request is fixing the unity versions scrapping.

The previous implementation was not returning all the versions anymore. The loop was stopping on the first non empty script tag containing at least one version. But currently it does not work.

The proposed fix is to loop on all the scripts tag, store all the versions in a map and returns them at the end.

It will probably fix the following issues: game-ci/docker#251, game-ci/docker#250

Checklist

• Read the contribution guide and accept the code of conduct
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[GabLeRoux]

This looks good to me, but I am unsure how this should be tested. The logic seems good:

• The fix iterates through all script tags on the page.
• It stores all found versions in a Map, ensuring all unique versions are collected.
• Finally, it returns all unique versions, not stopping at the first found version.

This logic seems to be in line with the problem as explained in the PR description.

[GabLeRoux]

🚀 / Test Deploy (pull_request) Failing, this seems to be due to unavailalbe env var for this pull-request run (fork):

Either FIREBASE_TOKEN or GCP_SA_KEY is required to run commands with the firebase cli

Not sure if we should do something about it.

The tests are passing. I haven't seen any tests covering scrapeVersions method, might be worth testing it. I am personally ok with this as is because chances are this fix will unblock quite a few users trying to use recent unity versions with GameCI docker images.

[brako]

I could add a test, but I'm unsure of the best way to implement it. Do you have any examples to share? We could check the number of versions returned by the scraping and determine that if it falls below a certain threshold, there's an issue. Currently, the scraping finds 576 versions.

As for the failing test, I'm not entirely familiar with the workflow, but it's possible that the failure is due to the pull request coming from a fork, which might be missing some GitHub secrets

[AndrewKahr]

Manually tested the code and the versions are now appearing to be scraped. Not sure how to make an automated test as the version count will always change so I think this can merge without one.

[MrGadget1024]

** Thank You @brako !! **