Skip to content

SRHD with CR#345

Open
ChunYen-Chen wants to merge 88 commits intogamer-project:mainfrom
ChunYen-Chen:CR_SRHD
Open

SRHD with CR#345
ChunYen-Chen wants to merge 88 commits intogamer-project:mainfrom
ChunYen-Chen:CR_SRHD

Conversation

@ChunYen-Chen
Copy link
Copy Markdown
Collaborator

@ChunYen-Chen ChunYen-Chen commented Aug 21, 2024

This PR includes the works Can the symmetric Fermi and eROSITA bubbles be produced by tilted jets? from @zengbs.

Updates

  1. SRHD supports CRs and gravity.
  2. New Fermi bubble test problem.

TODO

  • Upload the initial condition. (yt.upload is malfunctioning now)

Results

Fermi bubble test

@jzuhone
Copy link
Copy Markdown
Collaborator

jzuhone commented Aug 23, 2024

@ChunYen-Chen I see in your presentation these lines:

Code:
1. Add more unphysical checks. e.g. passive scalars
2. Bugs fix of EoS: The initial guess of HTilde when solving temperature.
3. The unit of temperature output is changed from code unit to Kelvin.

Regarding 2: we fixed such a bug in the merged SRHD PR. Was there another one?
Regarding 3: I thought that the output temperature units were already in Kelvin? We had this discussion previously as well, and yt certainly seems to think the units are Kelvin.

@hyschive
Copy link
Copy Markdown
Contributor

@jzuhone You are right that both 2 and 3 have already been merged into GAMER early this year in #185. IIUC, @ChunYen-Chen's slides are referring to @zengbs's own branch used in his Fermi/eROSITA bubbles paper that didn't incorporate #185.

@ChunYen-Chen @zengbs Please correct me if I'm wrong.

@hyschive hyschive self-requested a review September 9, 2024 03:42
@hyschive hyschive self-assigned this Sep 9, 2024
@hyschive hyschive added enhancement hydro Hydrodynamics test Test problems labels Sep 9, 2024
@ChunYen-Chen
Copy link
Copy Markdown
Collaborator Author

@hyschive The branch is updated to the latest main branch.

@ChunYen-Chen ChunYen-Chen mentioned this pull request Jan 22, 2025
@hyschive hyschive requested review from BinChian and removed request for hyschive February 10, 2026 04:41
@hyschive hyschive assigned BinChian and unassigned hyschive Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement hydro Hydrodynamics test Test problems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants