Skip to content

Add support for computing standard deviation in Aux_ComputeProfile#448

Merged
hyschive merged 8 commits intogamer-project:mainfrom
HsunYeong:main
Mar 15, 2026
Merged

Add support for computing standard deviation in Aux_ComputeProfile#448
hyschive merged 8 commits intogamer-project:mainfrom
HsunYeong:main

Conversation

@HsunYeong
Copy link
Copy Markdown
Contributor

Add Data_Sigma in Profile_t to store the standard deviation of Data, and compute it in Aux_ComputeProfile().

Copy link
Copy Markdown
Contributor

@hfhsieh hfhsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments.

@hyschive Should we enable this feature by default. I prefer to make it optional by adding a new parameter, such as const bool NeedDataStd, to Aux_ComputeProfile().

Comment thread include/Profile.h Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
@HsunYeong
Copy link
Copy Markdown
Contributor Author

Added parameter const bool GetSigma. It will skip some computation and set Prof[p]->Data_Sigma[b] to zero when GetSigma = false.

Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp
Copy link
Copy Markdown
Contributor

@hyschive hyschive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HsunYeong Thanks for the contribution! I only have a few minor comments, mostly related to improving code alignment. I'll merge this PR once they are addressed.

Comment thread src/SourceTerms/Deleptonization/CPU_Src_Deleptonization.cpp
Comment thread src/SourceTerms/Deleptonization/CPU_Src_Deleptonization.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
Comment thread src/Auxiliary/Aux_ComputeProfile.cpp Outdated
@hyschive hyschive merged commit c286c0c into gamer-project:main Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement tool Useful analysis and visualization tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants