Skip to content

feat(frontend) Move shoot-specific defaults from branching logic to vendor configurations - #3167

Draft
grolu wants to merge 3 commits into
gardener:masterfrom
grolu:codex/generic-shoot-configuration
Draft

feat(frontend) Move shoot-specific defaults from branching logic to vendor configurations#3167
grolu wants to merge 3 commits into
gardener:masterfrom
grolu:codex/generic-shoot-configuration

Conversation

@grolu

@grolu grolu commented Aug 12, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Moves shoot-specific defaults from branching logic in utils/shoot.js into the infrastructure vendor configurations.

This includes:

  • Provider, networking, and Kubernetes templates
  • Zone-networking strategies
  • Control-plane zone strategies
  • Provider-specific zone behavior
  • AWS worker volume and worker provider configuration

useShootContext now resolves these settings through the configured infrastructure vendor. The AWS IOPS behavior introduced by #2951 is preserved:

  • The provider type is read from cloudProfile.spec.type
  • IOPS is hidden for gp2
  • IOPS is required for io1 and io2

The PR also adds default shoot manifest coverage for all configured infrastructure providers and focused regression coverage for the AWS volume behavior.

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

This is intended to be a behavior-preserving refactoring that makes shoot defaults extensible through vendor configuration.
This is the last slice of #2824

Release note:

Infrastructure-provider shoot defaults and templates now live in the provider's `shoot` configuration under `frontend/src/data/vendors/infra` instead of provider-specific branching in `utils/shoot.js`

@gardener-prow

gardener-prow Bot commented Aug 12, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2026
@gardener-prow

gardener-prow Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign julestree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 68d4f71e-3152-4b44-a23d-b32d383deb53

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gardener-prow gardener-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 12, 2026
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant