Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEP 31] Introduce API changes for supporting InPlaceUpdate #962

Merged
merged 11 commits into from
Feb 24, 2025
Merged

[GEP 31] Introduce API changes for supporting InPlaceUpdate #962

merged 11 commits into from
Feb 24, 2025

Conversation

acumino
Copy link
Member

@acumino acumino commented Jan 15, 2025 •
edited by aaronfern
Loading

What this PR does / why we need it:
This PR introduces the necessary API changes to enable in-place updates for nodes, as outlined in gardener/gardener#10219.

Which issue(s) this PR fixes:
Part of #944
Part of gardener/gardener#10219

Special notes for your reviewer:

Release note:

Introduced API changes to support InPlaceUpdate

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Jan 15, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 15, 2025
@acumino
Copy link
Member Author

acumino commented Jan 15, 2025

/invite @unmarshall @rishabh-11

@acumino acumino marked this pull request as ready for review January 16, 2025 19:32
@acumino acumino requested a review from a team as a code owner January 16, 2025 19:32
@acumino acumino mentioned this pull request Jan 15, 2025
Open
12 tasks
@acumino
Copy link
Member Author

acumino commented Jan 22, 2025

/invite @elankath @aaronfern

@acumino acumino force-pushed the inplace-updates/api branch from 69a6063 to 7fd974d Compare January 31, 2025 11:42
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 31, 2025
@acumino acumino requested a review from unmarshall February 6, 2025 11:20
acumino and others added 4 commits February 6, 2025 19:11
@acumino @shafeeqes @ary1992
Introduce APIs for InPlaceUpdate
58a15a5 
Co-authored-by: Shafeeque E S <[email protected]>
Co-authored-by: Ashish Ranjan Yadav  <[email protected]>
@acumino @shafeeqes @ary1992
Adapt API changes
c80d837 
Co-authored-by: Shafeeque E S <[email protected]>
Co-authored-by: Ashish Ranjan Yadav  <[email protected]>
@acumino @shafeeqes @ary1992
Add validation for InPlaceUpdate strategy
c8c8161 
Co-authored-by: Shafeeque E S <[email protected]>
Co-authored-by: Ashish Ranjan Yadav  <[email protected]>
@acumino @shafeeqes @ary1992
Nits
03e077f 
Co-authored-by: Shafeeque E S <[email protected]>
Co-authored-by: Ashish Ranjan Yadav  <[email protected]>
@acumino acumino force-pushed the inplace-updates/api branch from 7fd974d to 03e077f Compare February 6, 2025 13:41
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 6, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 12, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2025
aaronfern
aaronfern approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Feb 17, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 17, 2025
aaronfern
aaronfern requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@aaronfern aaronfern left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on a call, requesting a few changes. Please review and adapt according to what was discussed
Thanks,
MCM team

@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Feb 18, 2025
@acumino acumino requested a review from aaronfern February 18, 2025 12:06
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 18, 2025
rishabh-11
rishabh-11 suggested changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some minor comments.

@acumino acumino requested a review from rishabh-11 February 20, 2025 05:28
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 20, 2025
unmarshall
unmarshall requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. One fixed we can merge it.

@acumino acumino requested a review from unmarshall February 21, 2025 05:49
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2025
@acumino acumino requested a review from aaronfern February 21, 2025 05:49
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 21, 2025
@gardener-robot
Copy link

@elankath You have pull request review open invite, please check

@aaronfern aaronfern merged commit 73405d0 into gardener:master Feb 24, 2025
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 24, 2025
@acumino acumino deleted the inplace-updates/api branch February 24, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafeeqes shafeeqes shafeeqes left review comments

@elankath elankath Awaiting requested review from elankath

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11

@unmarshall unmarshall Awaiting requested review from unmarshall

@aaronfern aaronfern Awaiting requested review from aaronfern

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@acumino @gardener-robot @unmarshall @shafeeqes @rishabh-11 @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3