Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cleanup of IT resources and processes #968

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Ensure cleanup of IT resources and processes #968

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
21fd746
refactor: extract cleanup fns & allow for cleanup in beforesuite
takoverflow Feb 13, 2025
4663654
fix: kill processes run by IT before and after running the suite
takoverflow Feb 14, 2025
830ab97
cleanup: remove CONTAINER_IMAGE checks and related fn
takoverflow Feb 17, 2025
663c421
refactor: added event based machineset freeze check instead of logs
takoverflow Feb 21, 2025
f3ae69f
framework: add changes to support virtual provider
takoverflow Feb 27, 2025
d610c1d
Address review comments
takoverflow Mar 3, 2025
e34f396
nit: rename to a sensible name
takoverflow Mar 3, 2025
bf357eb
Added constants for events, address review comments
takoverflow Mar 10, 2025
8024b71
bugfix: add supported argument on fetching process to kill
takoverflow Mar 10, 2025
2998539
chore: update ginkgo version and flags
takoverflow Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/controller/machine_safety.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ func (c *controller) freezeMachineSetAndDeployment(ctx context.Context, machineS
}
}

c.recorder.Eventf(machineSet, "Normal", "FrozeMachineSet", "SafetyController: Froze MachineSet %s due to replica overshooting", machineSet.Name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make constants for this FrozeMachineSet ? We have done this inconsistenly, See controller.emitRollbackNormalEven. But let us clean up the places instead ofusing literal strings. Also we should use corev1.EventTypeNormal

klog.V(2).Infof("SafetyController: Froze MachineSet %q due to overshooting of replicas", machineSet.Name)
return nil
}
Expand Down Expand Up @@ -398,6 +399,7 @@ func (c *controller) unfreezeMachineSet(ctx context.Context, machineSet *v1alpha
return err
}

c.recorder.Eventf(machineSet, "Normal", "UnfrozeMachineSet", "SafetyController: Unfroze MachineSet %s", machineSet.Name)
klog.V(2).Infof("SafetyController: Unfroze MachineSet %q", machineSet.Name)
return nil
}
Expand Down
Loading