Skip to content

fix(ratelimit): downgrade redis deadline logs - #26

Merged
garrettladley merged 1 commit into
mainfrom
gml/fix-rate-limit-timeout-sentry
Sep 12, 2026
Merged

garrettladley merged 1 commit into
mainfrom
gml/fix-rate-limit-timeout-sentry

Conversation

@garrettladley

Copy link
Copy Markdown
Owner
  • rateLimit now checks the request context before classifying store errors, preserving cancellation handling when redis returns a socket timeout
  • os.ErrDeadlineExceeded failures are logged at WARN so expected redis deadline noise does not create sentry error issues
  • rate-limit store failures remain fail closed with 503, and regression coverage reproduces the production poll.DeadlineExceededError shape

@garrettladley
garrettladley marked this pull request as ready for review September 12, 2026 23:16
@garrettladley
garrettladley enabled auto-merge (squash) September 12, 2026 23:16

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@garrettladley
garrettladley merged commit 6fb573e into main Sep 12, 2026
3 checks passed
@garrettladley
garrettladley deleted the gml/fix-rate-limit-timeout-sentry branch September 12, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant