feat: add code font size zoom control#141
Open
Sha17g wants to merge 1 commit into
Open
Conversation
Sha17g
force-pushed
the
feature/font-size-control
branch
from
08592cd to
3e917f2
Compare
ISSOtm
reviewed
May 31, 2026
| View | ||
| <ul> | ||
| <li> | ||
| <label> |
Contributor
There was a problem hiding this comment.
Probably just copy-pasted from the others. When a <label> wraps text and a single <input>, like in #143, then it allows clicking the text to affect the input. But here there are two buttons, so the "Font size:" label shouldn't actually be a <label> for either of them.
Rangi42
requested changes
Jun 7, 2026
Rangi42
left a comment
Rangi42
left a comment
Contributor
There was a problem hiding this comment.
Thanks; please just remove the <label> and fix the merge conflict, and then I think this will be ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The font size is changeable by using keyboard shortcuts or the new buttons.
Apart from the newly added buttons and shortcut keys, there are no other changes.
The feature is implemented through ACE editor API.