French german #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some debugging info added to region JS
…med. Removes the old cookie logic, which was messing up when the page was already in local cache.
…ecking to skip when visiting a site and then browsing to another siteaccess) Dynamically looks up the d18n variables for the region alert dialog box and buttons and uses those (based on the user's detected siteaccess) Altered JS flow so that region checking is only skipped once the user has seen the region prompt (regardless of what they clicked on) Simplified the region_alert dialog box to not generate any button text. This didn't always work properly anyway, because of Varnish caching for the wrong region.
Switch to setting the flag into session storage to try and catch repeat visitors that have come back to the site via google.
… (rather than letting the redirect kick it around)
…ead of just doing a string replace
…. There appears to be a bug where retrieving the cached translations always retrieves for the default locale, even when that's not the one you're translating.
Removed the load() function, which seems to never be called and does a massive amount of outdated cookie stuff. Refactored to not use session variables (these kill Varnish caching).
… on /content paths)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding French and German translations
N.B For testing this will need to trick the region module into thinking you are from a French or German IP address can be done by sending a German or French IP address to getRegionalData on line 264 of classes/ezxregion.php
128.65.210.182 - German IP
62.210.16.2 - French IP