Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1589
When Input is encoded with an offset and spaces it is possible for white space characters to be placed at the beginning or end of the output text. If these characters are trimmed, then decoding will not work without manually adding them back in. For example encoding the text "No one expects the Spanish Inquisition." with the settings key:3 Offset:2 will move 2 spaces to the beginning of the cipher text. So when they are removed by .trim() it makes the decode function unable to recover the original text.
So I just removed the 2 calls to trim, and added in a test using the example above.