Skip to content

Conversation

patchwork01
Copy link
Collaborator

@patchwork01 patchwork01 commented Aug 28, 2025

Make sure you have checked all steps below.

Issue

  • My PR fully resolves the following issues. I've referenced an issue in the PR title, for example "Issue 1234 - My
    Feature". Note that before an issue is finished, you can still make a pull request by raising a separate issue
    for your progress.

Tests

  • My PR adds the following tests based on our test strategy OR does not need testing for this extremely good reason:
    • CompactionVeryLargeST
    • Passed in AWS

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added new Java code, I have added Javadoc that explains it following our conventions and style.
  • If I have added or removed any dependencies from the project, I have updated the NOTICES file.

sleeper.compaction().scaleToZero();
}

@Test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the size and nature of this test, might it be worth having a comment at the top here to describe the expected behaviour, time taken, any other key details?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add that when I've run it and seen how long it takes.

Copy link
Collaborator

@rtjd6554 rtjd6554 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed with comment for potential comment for more info

@patchwork01 patchwork01 marked this pull request as ready for review September 9, 2025 11:43
@patchwork01 patchwork01 marked this pull request as draft September 9, 2025 11:43
@patchwork01 patchwork01 marked this pull request as ready for review September 9, 2025 13:40
@patchwork01 patchwork01 merged commit abbc7ef into develop Sep 10, 2025
8 checks passed
@patchwork01 patchwork01 deleted the 5216-system-test-large-compaction branch September 10, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System test a very large compaction
3 participants