Solr search #1882
Open
Solr search #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* modified plugin to work with new configuration for solr
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
… into solr_search
* searching for group and user fixed (removed subtype) * displaying correct information fixed
Phanoix
requested changes
Jul 13, 2018
mod/elgg_solr/lib/functions.php
Outdated
| @@ -514,9 +514,9 @@ function elgg_solr_get_default_fq($params) { | |||
| $fq['access'] = $access_query; | |||
| } | |||
|
|
|||
| if (!access_get_show_hidden_status()) { | |||
| /*if (!access_get_show_hidden_status()) { | |||
| @@ -36,9 +36,11 @@ function elgg_solr_init() { | |||
| elgg_register_plugin_hook_handler('search', 'object', 'elgg_solr_object_search'); | |||
| elgg_register_plugin_hook_handler('search', 'user', 'elgg_solr_user_search'); | |||
| elgg_register_plugin_hook_handler('search', 'group', 'elgg_solr_group_search'); | |||
| elgg_register_plugin_hook_handler('search', 'tags', 'elgg_solr_tag_search'); | |||
| //elgg_register_plugin_hook_handler('search', 'tags', 'elgg_solr_tag_search'); | |||
There was a problem hiding this comment.
we may need that later (i'm not sure) it just searches for tags
mod/elgg_solr/lib/hooks.php
Outdated
| @@ -11,10 +11,12 @@ | |||
| */ | |||
| function elgg_solr_file_search($hook, $type, $value, $params) { | |||
|
|
|||
| $set_language = get_language(); | |||
There was a problem hiding this comment.
Nothing wrong, just sounds weird.
There was a problem hiding this comment.
$set_language has been set to $get_language
There was a problem hiding this comment.
exactly, no problem with the logic or anything just reads a little weird. One might expect set_ and get_ language to both be functions at a quick glance. Up to you if you want to do anything with that.
mod/elgg_solr/lib/hooks.php
Outdated
| // get highlighting component and apply settings | ||
| $hl = $query->getHighlighting(); | ||
| $hlfields = array('name', 'username', 'description'); | ||
| $hlfields = array('text_en'); |
There was a problem hiding this comment.
changed to $hlfields = array("text_{$get_language}");
Phanoix
approved these changes
Jul 13, 2018
|
This is completely unrelated to / does not affect the connex side and is only for the collab-related solr agent right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue in the GCcollab repository.
gctools-outilsgc/gccollab#336
The following files have been changed:
composer installAdditional Information
composer install