Skip to content

Conversation

@JR-1991
Copy link
Member

@JR-1991 JR-1991 commented May 29, 2024

Overview

This pull request resolves the issue where the update method fails to properly update multiple added compounds. With this pull request, newly added lists of compounds are now directly included. Additionally, a test case has been added to ensure proper functionality.

TLDR

  • Fix update not adding multiple compounds
  • Added test case for this issue

@JR-1991 JR-1991 added the bug Something isn't working label May 29, 2024
@JR-1991 JR-1991 added this to the 0.4.2 milestone May 29, 2024
@JR-1991 JR-1991 self-assigned this May 29, 2024
@pdurbin
Copy link
Member

pdurbin commented Apr 16, 2025

to test:

pip install pytest-cov
pip install -e .

export BASE_URL=<URL>
export API_TOKEN=<Token>
export DVUPLOADER_TESTING=True

pytest -vv tests/integration/test_dataset_update.py  

@JR-1991 JR-1991 removed this from the 0.4.3 milestone Apr 16, 2025
@JR-1991
Copy link
Member Author

JR-1991 commented Sep 22, 2025

Fixed in #65

@JR-1991 JR-1991 closed this Sep 22, 2025
@JR-1991 JR-1991 deleted the fix-update-not-adding-multiples branch September 22, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants