Fix: _get_version in datasettype.py
#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… version numbers (including versions with leading strings, like v6.1.0)
Member
|
@kenlhlui thanks for the fix. Looks good to me 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a similar issue from #58 in the latest commit (1eccb26) of the
mainbranch, where the_get_versionin datasettype does not handle version numbers with non-numeric characters.Since the
datasettypeanddataversemodules both check the Dataverse instance's version, this PR moved theextract_major_minorfunction to theutilsmodule so that the two modules can jointly use it.