Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-qgis dependency #241

Closed
wants to merge 1 commit into from
Closed

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Remove pytest-qgis from dependencies

How to test it

  • See CI/run tests locally

Other notes

I tried using the fixtures again, and they have null references. We built our whole test suite without pytest-qgis, and it seems we would be adding significant overhead to add maintenance of it. All of our tests pass without it; I think we should remove the dependency.

@zacdezgeo zacdezgeo requested a review from alukach March 10, 2025 17:31
@zacdezgeo zacdezgeo self-assigned this Mar 10, 2025
Copy link
Collaborator

@alukach alukach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, less is more! 🧹

@zacdezgeo
Copy link
Collaborator Author

oh, I started digging into replacing the qgis_app references in the fixtures. Turns out the pytest-qgis is doing more than I expected. I think it's worth keeping it for now.

@zacdezgeo zacdezgeo closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants