Resolve issue #14 consecutive spaces #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcool
changed the title
|
Thank you! I'm reviewing this changes and adding them on the next version. |
|
No problem! Thanks for writing this library!
I've got a couple more PRs on the way or already submitted. I'm still new
at contributing to projects of GitHub, please let me know if there are
things I should do differently.
Joe
…On Wed, Nov 10, 2021 at 2:14 PM Rubén Santa Anna ***@***.***> wrote:
Thank you!
I'm reviewing this changes and adding them on the next version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARPJHSPTFYMRDEDJM5RTGTLULLAC7ANCNFSM5HWRBPAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #14, consecutive spaces results in multiple empty arguments. This PR adds a loop in the shell_parse function which skips consecutive spaces so that empty arguments aren't added.