Bugfix/php8.5 opcache removal - #447
Open
bigcalm wants to merge 3 commits into
Open
Conversation
… is no install candidate for PHP 8.5 References: 1. https://wiki.php.net/rfc/make_opcache_required 2. https://www.php.net/manual/en/migration85.other-changes.php
…ked into PHP from version 8.5)
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark issues as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 8.5, OPcache has been baked in. Meaning that
php{8.5}-opcacheno longer has an install candidate on Debian unstable.The PR removes
-opcachefrom the list of packages to be installed. But then attempts to install it viatasks/main.ymlif the version of PHP < 8.5.Additionally, the
opcache.sobinary will not be available. Theopcache.initemplate omits referencing the binary unless the version of PHP is < 8.5.Note that the README.md still refers to opcache.so as I am not sure how you would want to document the change in PHP 8.5 (line 134):
PR #402 used for inspiration.
Fixes issue #446