Resolve dependency issues from Debian Bookwrom and improve resolvconf update #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geerlingguy Would love to get a review on this so that we can fix the main setup here for anybody coming with a fresh Pi OS installation 🚀 |
|
I highly recommend using The better solution will be to follow this guide and get Debian to not be so persnickety. |
|
@geerlingguy That makes sense, thanks for sharing. I'll try and push an update to the PR if I find time. |
jan-chvojka
added a commit
to jan-chvojka/internet-pi
that referenced
this pull request
Apr 10, 2024
commit 0ecbedb Author: Martin Brose <[email protected]> Date: Sun Mar 3 21:43:35 2024 +0000 Fix issue with 2 depends_on in same yaml section (geerlingguy#583) commit 8b470f3 Author: Jeff Geerling <[email protected]> Date: Sat Feb 3 22:18:40 2024 -0600 Issue geerlingguy#575: Update remaining instances of old docker-compose command. commit d4170cf Author: Jeff Geerling <[email protected]> Date: Sat Feb 3 22:06:54 2024 -0600 Issue geerlingguy#575: Make sure handler syntax is correct for compose v2. commit 7c20fbd Author: Jeff Geerling <[email protected]> Date: Sat Feb 3 21:28:29 2024 -0600 Issue geerlingguy#575: Follow-ups to make sure initial install works well. commit 38a240b Author: Jeff Geerling <[email protected]> Date: Sat Feb 3 21:06:11 2024 -0600 Fixes geerlingguy#575: Use new docker_compose_v2 plugin. commit d53939c Author: Cedric Wille <[email protected]> Date: Sat Feb 3 21:49:04 2024 -0500 Resolve dependency issues from Debian Bookwrom and improve resolvconf update (geerlingguy#565) * Fix docker setup * Fix missing resolvconf * Update README * Fix permission issue for CI * Fix CI error commit 4c0bb07 Author: Jeff Geerling <[email protected]> Date: Sat Feb 3 20:47:53 2024 -0600 Fixes geerlingguy#569: Updated instructions inside Internet Monitoring directory. commit 7925370 Author: James Byers <[email protected]> Date: Tue Aug 22 04:29:56 2023 +0200 Set allowUiUpdates: true to allow saving dashboard state and adding new dashboards (geerlingguy#541) commit c8d3f40 Author: Nick Bachicha <[email protected]> Date: Wed Aug 16 18:46:38 2023 -0600 Add missing Buster backports apt keys (geerlingguy#538) commit 98c83ad Author: jerzerisz <[email protected]> Date: Mon Jul 17 22:24:01 2023 -0400 update container tags to :latest (geerlingguy#524) added volume: - /etc/localtime:/etc/localtime:ro to syncronize time & timezone to containers commit 7657dd9 Author: Jeff Geerling <[email protected]> Date: Mon Jul 10 16:53:19 2023 -0500 Fixing some linting. commit e3d1875 Author: Jeff Geerling <[email protected]> Date: Mon Jul 10 16:48:27 2023 -0500 Make stale workflow run to test it. commit 088962e Author: Jeff Geerling <[email protected]> Date: Mon Jul 10 16:46:43 2023 -0500 Move stale workflow into workflows directory. commit a7705f9 Author: jerzerisz <[email protected]> Date: Mon Jul 10 17:38:01 2023 -0400 update stale actions per: (geerlingguy#529) https://docs.github.com/en/actions/managing-issues-and-pull-requests/closing-inactive-issues commit e605493 Author: Gianpaolo Macario <[email protected]> Date: Tue Jun 13 06:30:11 2023 +0200 README.md: Use relative URL for images (geerlingguy#517) Small fix to be able to display inline images when the repository is imported as a git submodule commit f4de972 Author: Jeff Geerling <[email protected]> Date: Mon Feb 20 22:38:08 2023 -0600 Some Linty fixes. commit 861e0f4 Author: Jeff Geerling <[email protected]> Date: Mon Feb 20 21:22:01 2023 -0600 Issue geerlingguy#492: Update pi-hole tasks to use path from first task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily intends to fix a problem that was introduced in Debian Bookworm, which broke the Ansible playbook. While setting this up on a Pi with the latest image, I was able to troubleshoot the
pipdependency issues and replace them withapt. Additionally, my Pi did not haveresolvconfinstalled which caused Ansible to blow up, so I added that to the Debian dependencies, and also used Ansible to create theresolvconf.conffile if it does not exist. Finally, I made a few tweaks in the README to fix a typo, reflect the current admin portal for Pihole, and update the setup instructions to fix thepipissue.Note
resolvconfto thepacmandependencies, although it may need to be added there as well. It looks like Arch / pacman has docker-compose too