Fixes to sync() #866
Merged
Fixes to sync() #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Save/sync executor attempted to commit changes to pydantic objects even when there was an exception inside its context manager * Sync was writing changes to pydantic objects while the transaction was still open * Fix sync() to update single links properly and handle the case when a linked object is replaced with a different one * Drop BlockingClient.__save_debug__ method, it's quite outdated and must be broken
1st1
force-pushed
the
hello_darkness_my_old_friend
branch
from
bac5d1b to
1dc77a6
Compare
elprans
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save/sync executor attempted to commit changes to pydantic objects even when there was an exception inside its context manager
Sync was writing changes to pydantic objects while the transaction was still open
Fix sync() to update single links properly and handle the case when a linked object is replaced with a different one
Drop BlockingClient.save_debug method, it's quite outdated and must be broken