Merge pull request #494 from gemini-testing/HERMIONE-1145.fix_suites_…

…state fix: suites state with empty picked browsers
gemini-testing · Sep 5, 2023 · 854c9f0 · 854c9f0
2 parents 469387f + 2fc0aff
commit 854c9f0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/lib/static/modules/reducers/tree/index.js b/lib/static/modules/reducers/tree/index.js
@@ -1,4 +1,4 @@
-import {findLast} from 'lodash';
+import {findLast, isEmpty} from 'lodash';
 import {produce} from 'immer';
 import actionNames from '../../action-names';
 import {
@@ -108,8 +108,11 @@ export default produce((state, action) => {
 
         case actionNames.BROWSERS_SELECTED: {
             const {tree, view} = state;
+            const filteredBrowsers = isEmpty(view.filteredBrowsers)
+                ? state.browsers.map(({id}) => ({id, versions: []}))
+                : view.filteredBrowsers;
 
-            updateAllSuitesStatus(tree, view.filteredBrowsers);
+            updateAllSuitesStatus(tree, filteredBrowsers);
             calcBrowsersShowness(tree, view);
             calcSuitesShowness(tree);
 

diff --git a/test/unit/lib/static/modules/reducers/tree/index.js b/test/unit/lib/static/modules/reducers/tree/index.js
@@ -985,6 +985,22 @@ describe('lib/static/modules/reducers/tree', () => {
             assert.equal(newState.tree.suites.byId.s1.status, FAIL);
             assert.equal(newState.tree.suites.byId.s2.status, SUCCESS);
         });
+
+        it('should correctly set suite status when filteredBrowsers is empty', () => {
+            const suitesById = mkSuite({id: 's1', status: FAIL, browserIds: ['b1']});
+            const browsersById = mkBrowser({id: 'b1', name: 'yabro-1', parentId: 's1', resultIds: ['r1']});
+            const resultsById = mkResult({id: 'r1', parentId: 'b1', status: FAIL});
+            const browsersStateById = {'b1': {checkStatus: UNCHECKED}};
+            const tree = mkStateTree({suitesById, browsersById, resultsById, browsersStateById});
+            const view = mkStateView({filteredBrowsers: [{id: 'yabro-1', versions: []}]});
+
+            const newState = reducer({tree, view}, {
+                type: actionNames.BROWSERS_SELECTED,
+                payload: {browsers: []}
+            });
+
+            assert.equal(newState.tree.suites.byId.s1.status, FAIL);
+        });
     });
 
     describe(`${actionNames.CHANGE_TEST_RETRY} action`, () => {